Merge pull request #1540 from 0chain/fix/connection-update

Delete committed connections

Author: dabasov

code/go/0chain.net/blobbercore/allocation/allocationchange.go

@@ -161,7 +161,6 @@ func GetAllocationChanges(ctx context.Context, connectionID, allocationID, clien
 		cc.ComputeProperties()
 		// Load connection Obj size from memory
 		cc.Size = GetConnectionObjSize(connectionID)
-		cc.Status = InProgressConnection
 		return cc, nil
 	}
 

code/go/0chain.net/blobbercore/handler/worker.go

@@ -79,7 +79,7 @@ func cleanupTempFiles(ctx context.Context) {
 	then := now.Add(time.Duration(-config.Configuration.OpenConnectionWorkerTolerance) * time.Second)
 
 	var openConnectionsToDelete []allocation.AllocationChangeCollector
-	db.Table((&allocation.AllocationChangeCollector{}).TableName()).Where("updated_at < ? AND status IN (?,?)", then, allocation.NewConnection, allocation.InProgressConnection).Preload("Changes").Find(&openConnectionsToDelete)
+	db.Table((&allocation.AllocationChangeCollector{}).TableName()).Where("updated_at < ?", then).Preload("Changes").Find(&openConnectionsToDelete)
 
 	for i := 0; i < len(openConnectionsToDelete); i++ {
 		connection := &openConnectionsToDelete[i]
@@ -93,10 +93,12 @@ func cleanupTempFiles(ctx context.Context) {
 		nctx := datastore.GetStore().CreateTransaction(ctx)
 		ndb := datastore.GetStore().GetTransaction(nctx)
 		var errorOccurred bool
-		for _, changeProcessor := range connection.AllocationChanges {
-			if err := changeProcessor.DeleteTempFile(); err != nil {
-				errorOccurred = true
-				logging.Logger.Error("AllocationChangeProcessor_DeleteTempFile", zap.Error(err))
+		if connection.Status == allocation.InProgressConnection || connection.Status == allocation.NewConnection {
+			for _, changeProcessor := range connection.AllocationChanges {
+				if err := changeProcessor.DeleteTempFile(); err != nil {
+					errorOccurred = true
+					logging.Logger.Error("AllocationChangeProcessor_DeleteTempFile", zap.Error(err))
+				}
 			}
 		}
 

goose/migrations/1742282974_cleanup_connections.sql

@@ -0,0 +1,6 @@
+-- +goose Up
+-- +goose StatementBegin
+
+DELETE FROM allocation_connections WHERE status = 2 OR status = 3;
+
+-- +goose StatementEnd